diff options
Diffstat (limited to 'tasks/20261014-192305/TASK.md')
| -rw-r--r-- | tasks/20261014-192305/TASK.md | 22 |
1 files changed, 21 insertions, 1 deletions
diff --git a/tasks/20261014-192305/TASK.md b/tasks/20261014-192305/TASK.md index 6442a5a..828e130 100644 --- a/tasks/20261014-192305/TASK.md +++ b/tasks/20261014-192305/TASK.md @@ -1,6 +1,6 @@ # Review and remove unused HEX conversion surface -- STATUS: OPEN +- STATUS: CLOSED - PRIORITY: 170 - TAGS: review,cleanup,core @@ -13,3 +13,23 @@ Approach: Search all references first, including documentation and published pat Completion checks: swift build and swift test pass; no dangling HEX symbol links or references remain. Supported hex syntax and Config appearance are unchanged. Explain the kept/removed API choice in the change description so it can be reviewed separately from strict input validation. Design constraint: Follow README.md: keep source-based configuration, no dependencies or plugin framework, and use the smallest readable change that makes the existing behavior reliable. This is a suggestion for individual review, not a deadline. Findings were recorded on 2026-10-14; re-check the current code before implementing. + +## Completion + +Reference review found no callers of the HEX wrapper, Color.init(hex:), or +Color.Resolved.hex in Sources, Tests, examples, or published patches. Removed +these unused conversions to keep source customization focused on the existing +Color.hex(String) helper. Moved that helper to Models/Color+Hex.swift and updated +Config and DocC references. The published background-blur patch uses only the +retained .hex(String) helper and needs no change. + +This is API simplification, separate from strict input validation: the parser +body is byte-for-byte unchanged, as are configured foreground, background, and +highlight values. Supported syntax and existing malformed-input behavior remain +unchanged. Users with private customizations that call the removed helpers can +use Color.hex(code) for forward conversion or keep their own conversion helpers. + +Validation: swift build succeeded; swift test passed all four existing tests; +make -C Sources/bar/bar.docc build completed without warnings or unresolved +links; reference search found no remaining removed-API references in Sources, +Tests, patches, or README; git diff --check passed. |