From 9ce5b3b6d52368b9333a9d5f98c3cd2b1a3cb038 Mon Sep 17 00:00:00 2001 From: Tommaso Negri Date: Thu, 15 Oct 2026 11:07:41 +0200 Subject: add tests --- tasks/20261014-192052/TASK.md | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'tasks/20261014-192052/TASK.md') diff --git a/tasks/20261014-192052/TASK.md b/tasks/20261014-192052/TASK.md index 8165a59..de0ca34 100644 --- a/tasks/20261014-192052/TASK.md +++ b/tasks/20261014-192052/TASK.md @@ -1,6 +1,6 @@ # Replace the placeholder test with focused protocol tests -- STATUS: OPEN +- STATUS: CLOSED - PRIORITY: 140 - TAGS: review,quality,tests @@ -13,3 +13,13 @@ Approach: Replace example() with named Swift Testing cases for Runner.parse: emp Completion checks: swift test executes meaningful assertions and all pass. Tests describe public behavioral contracts rather than copying implementation logic or relying on the user's scripts/hardware. Keep process fixtures bounded and deterministic. No screenshot suite, testing dependency, or general mock framework is required. Design constraint: Follow README.md: keep source-based configuration, no dependencies or plugin framework, and use the smallest readable change that makes the existing behavior reliable. This is a suggestion for individual review, not a deadline. Findings were recorded on 2026-10-14; re-check the current code before implementing. + +Completed 2026-10-15: the placeholder had already been replaced by the concurrent +pipe-draining task. Added six named, direct Runner.parse tests covering empty +output, one final newline, internal/leading blank lines, extra trailing blank +lines, line order, and spaces/tabs. No production changes or process fixtures +were needed. Highlight edge cases remain with task 20261014-191535, where their +contract is to be defined; repeated-cell identity stays with its dedicated task. + +Validation: `swift test` passes all 19 tests, including the six new protocol +tests. `git diff --check` passes. -- cgit v1.2.3