diff options
| author | Tommaso Negri <me@tommasongr.com> | 2026-10-14 21:58:57 +0200 |
|---|---|---|
| committer | Tommaso Negri <me@tommasongr.com> | 2026-10-14 21:58:57 +0200 |
| commit | f802039757d5da01a2b7cb7d1b15c692f137d91f (patch) | |
| tree | 86c328bda63b0d566eb56c8d0c83409fcc9b8b8c /tasks/20261014-191932 | |
| parent | e6b4d0cb69809ea3d742ba03f4a0586cbbb3d1b3 (diff) | |
| download | bar-f802039757d5da01a2b7cb7d1b15c692f137d91f.tar.gz bar-f802039757d5da01a2b7cb7d1b15c692f137d91f.zip | |
add tasks
Diffstat (limited to 'tasks/20261014-191932')
| -rw-r--r-- | tasks/20261014-191932/TASK.md | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/tasks/20261014-191932/TASK.md b/tasks/20261014-191932/TASK.md new file mode 100644 index 0000000..9936035 --- /dev/null +++ b/tasks/20261014-191932/TASK.md @@ -0,0 +1,15 @@ +# Repair the screen hotplug patch and preserve visibility + +- STATUS: OPEN +- PRIORITY: 130 +- TAGS: review,bug,patches + +Files: patches/patch-screen_hotplug-20260810-f6805c9.patch, Sources/bar/Views/AppDelegate.swift, Sources/bar/bar.docc/patches/patch-screen-hotplug.md. + +Observed: The patch targets Sources/bar/Models/AppDelegate.swift, which no longer exists. Its rebuilding code calls orderFrontRegardless for every window, so review whether a previously hidden bar would be unexpectedly shown after a screen change. + +Approach: Regenerate the optional feature against a documented clean base using the current Views path. Rebuild windows for current display geometry, retain the shared blocks without restarting their timers, and explicitly preserve hide/show state. Verify Swift 6 actor isolation of the notification callback and remove its observer on termination. Ensure discarded windows and event monitors are released. Update filename date/base revision and documentation links. + +Completion checks: git apply --check and patched swift build pass. Connect/disconnect a display and change display arrangement/resolution; windows match current frames with no stale bar. Repeat while hidden: it stays hidden until bar.show. Confirm block execution does not multiply and gestures still work after rebuilding. + +Design constraint: Follow README.md: keep source-based configuration, no dependencies or plugin framework, and use the smallest readable change that makes the existing behavior reliable. This is a suggestion for individual review, not a deadline. Findings were recorded on 2026-10-14; re-check the current code before implementing. |